[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0f38bb5186: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D136209#3880121 , @zequanwu wrote: > In D136209#3878821 , @labath wrote: > >> So if I understand

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3878821 , @labath wrote: > So if I understand correctly, when we deserialize incorrectly, this causes us > to misclassify some function parameters (arguments) as local variables. Is > that correct? If yes, then that

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

labath added a comment. So if I understand correctly, when we deserialize incorrectly, this causes us to misclassify some function parameters (arguments) as local variables. Is that correct? If yes, then that is something that can be checked. Even if the misclassified variables behave

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu added a comment. In D136209#3866933 , @rnk wrote: > Right, so `cantFail` must be an assertions-only check. That's not great. With assertion enabled, lldb still silently deserialize member functions as non-member functions. My guess is that

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

labath added a comment. Given what Reid said, would it be possible to make a test case that fails in an asserts build? Or was it maybe failing already there? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136209/new/

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

rnk added a comment. Right, so `cantFail` must be an assertions-only check. That's not great. These deserialization APIs have really, really bad ergonomics and could use a lot of improvement if you want to look into that. It would be really nice if, for example, this worked more like dyn_cast.

[Lldb-commits] [PATCH] D136209: [LLDB][NativePDB] Fix parameter size for member functions LF_MFUNCTION

zequanwu created this revision. zequanwu added reviewers: labath, rnk. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix the problem that it was treating member functions as non-member functions when