mgorny added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136551/new/
https://reviews.llvm.org/D136551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rG52f39853abd4: [lldb] Include gtest in standalone build only
if LLDB_INCLUDE_TESTS (authored by mgorny).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D136551?vs=469980&
labath added inline comments.
Comment at: lldb/CMakeLists.txt:20
+option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests."
${LLVM_INCLUDE_TESTS})
+
mgorny wrote:
> labath wrote:
> > mgorny wrote:
> > > To be honest, I don't exactly like movi
mgorny added inline comments.
Comment at: lldb/CMakeLists.txt:20
+option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests."
${LLVM_INCLUDE_TESTS})
+
labath wrote:
> mgorny wrote:
> > To be honest, I don't exactly like moving this `option`. Th
labath added inline comments.
Comment at: lldb/CMakeLists.txt:20
+option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests."
${LLVM_INCLUDE_TESTS})
+
mgorny wrote:
> To be honest, I don't exactly like moving this `option`. The alternative I
>
mgorny added inline comments.
Comment at: lldb/CMakeLists.txt:20
+option(LLDB_INCLUDE_TESTS "Generate build targets for the LLDB unit tests."
${LLVM_INCLUDE_TESTS})
+
To be honest, I don't exactly like moving this `option`. The alternative I can
think of is m
mgorny created this revision.
mgorny added reviewers: labath, JDevlieghere, tstellar, MaskRay.
Herald added a subscriber: StephenFan.
Herald added a project: All.
mgorny requested review of this revision.
Build gtest targets when building standalone only if LLDB_INCLUDE_TESTS
is true. Prior to th
