[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. In D136572#3890835 , @mgorny wrote: > In D136572#3889317 , @mstorsjo > wrote: > >> Also for the record, I'd love to get rid of this symlink based setup, if I >> could make cmake

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dd01a5241dc: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. In D136572#3889317 , @mstorsjo wrote: > Also for the record, I'd love to get rid of this symlink based setup, if I > could make cmake produce project files where caching works in the same way. > The main requirement for that

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. Also for the record, I'd love to get rid of this symlink based setup, if I could make cmake produce project files where caching works in the same way. The main requirement for that would be to have the whole cmake build started from the toplevel llvm-project directory

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo accepted this revision. mstorsjo added a comment. In D136572#3888630 , @mgorny wrote: > @mstorsjo, could you check this version? LGTM, this seems to work for my usecase (with lld,lldb,clang enabled this way). Thanks for the quick revert and

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

MaskRay added a comment. It'll be good if we have a wiki describing how downstream users invoke cmake, so that large cmake refactoring can be verified beforehand. (like usage verification https://github.com/opencollab/llvm-toolchain-integration-test-suite, but for cmake invocations) CHANGES

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a reviewer: mstorsjo. mgorny added a comment. @mstorsjo, could you check this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 471173. mgorny added a comment. Move `LLVM_COMMON_CMAKE_UTILS` earlier and use it for CMakePolicy path. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 Files: clang/CMakeLists.txt

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. I've reverted it right now, and I'll update the patch later today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ lldb-commits

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. In D136572#3888177 , @mstorsjo wrote: > This broke builds where clang/lld/lldb are symlinked into `llvm/tools` > instead of specified via `LLVM_ENABLE_PROJECTS` - since > `${CMAKE_CURRENT_SOURCE_DIR}/../cmake` doesn't find

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mstorsjo added a comment. Herald added subscribers: JDevlieghere, jdoerfert. This broke builds where clang/lld/lldb are symlinked into `llvm/tools` instead of specified via `LLVM_ENABLE_PROJECTS` - since `${CMAKE_CURRENT_SOURCE_DIR}/../cmake` doesn't find anything in that context. (The reason

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88d7508dc479: Harmonize cmake_policy() across standalone builds of all projects (authored by mgorny). Herald added projects: clang, LLDB, Flang.

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added a comment. Thanks. Since this is not urgent, I'll let it wait for others to chime in a while more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470225. mgorny edited the summary of this revision. mgorny added a comment. Herald added a project: LLVM. Use a shared policy file via `include()` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) nickdesaulniers wrote: > Seems error prone. Does cmake have

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

nickdesaulniers added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) Seems error prone. Does cmake have an include

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470108. mgorny retitled this revision from "[lld] Copy cmake_policy() to silence CMake warnings in standalone builds" to "Harmonize cmake_policy() across standalone builds of all projects". mgorny edited the summary of this revision. mgorny added reviewers: