jgorbe created this revision.
jgorbe added reviewers: yinghuitan, clayborg.
jgorbe added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
jgorbe requested review of this revision.
In some occasions, SBValue::GetError can invalidate its cached
`m_summary_str` m
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136890/new/
https://reviews.llvm.org/D136890
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7d4d25c42a68: [lldb-vscode] Don't call SBValue.GetError
after generating a summary. (authored by jgorbe).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D13689
yinghuitan added inline comments.
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:143
+llvm::StringRef value = v.GetValue();
+llvm::StringRef summary = v.GetSummary();
+llvm::StringRef type_name = v.GetType().GetDisplayTypeName();
Sorry for the late
clayborg added inline comments.
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:143
+llvm::StringRef value = v.GetValue();
+llvm::StringRef summary = v.GetSummary();
+llvm::StringRef type_name = v.GetType().GetDisplayTypeName();
yinghuitan wrote:
> S
