[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG868186cf6cb7: [lldb] Make callback-based formatter matching available from the CLI. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 474573. jgorbe added a comment. - Clarified help text for `--recognizer-function` as suggested by reviewer. Instead of "Incompatible with --regex (-x)." now it says "Cannot be specified at the same time as --regex (-x)." - Rebased on top of current HEAD. CH

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. In D137000#3915943 , @jingham wrote: > It is a bit odd to follow the what the help summary says is a valid option > set and then get an error. But this is a corner case, and since you say > explicitly that you can't provide bot

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham added a comment. In D137000#3902217 , @labath wrote: > In D137000#3897878 , @jgorbe wrote: > >> I'm looking at the option of using a non-printable character for the short >> flag, and at the same time mak

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It is a bit odd to follow the what the help summary says is a valid option set and then get an error. But this is a corner case, and since you say explicitly that you can't provide both th

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. @jingham any comments on https://reviews.llvm.org/D137000#3897162? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137000/new/ https://reviews.llvm.org/D137000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

labath added a comment. In D137000#3897878 , @jgorbe wrote: > I'm looking at the option of using a non-printable character for the short > flag, and at the same time make `--regex` and `--recognizer-function` > mutually exclusive using option groups. On

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe updated this revision to Diff 472185. jgorbe added a comment. - Removed `-R` short option to avoid confusion with regex. Updated doc, test case, and example. - Added some logic to make `--recognizer-function` and `--regex` mutually exclusive. Specifying both now results in an error being

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. I'm looking at the option of using a non-printable character for the short flag, and at the same time make `--regex` and `--recognizer-function` mutually exclusive using option groups. One problem I see is that the command help gets pretty confusing. Using a non-printabl

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe added a comment. > You can't provide the --regex option and this matcher at the same time Thanks for spotting this. I'll get to it. > it is also an error to have both this matcher function and any arguments in > the argument list Not with the code as it is. I've made the new flag have s

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks good. The one detail that remains is error handling for the command. You can't provide the --regex option and this matcher at the same time, and it is also an error to

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

labath added a comment. Seems fine to me. Comment at: lldb/source/Commands/Options.td:1231 Desc<"Type names are actually regular expressions.">; + def type_synth_add_recognizer_function : Option<"recognizer-function", "R">, +Desc<"Type names are actually the names of

[Lldb-commits] [PATCH] D137000: [lldb] Make callback-based formatter matching available from the CLI.

jgorbe created this revision. jgorbe added reviewers: jingham, labath. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This change adds a `--recognizer-function` (`-R`) to `type summary add` and `type syn