[Lldb-commits] [PATCH] D137684: Make sure we are stopped before we try to install functions into the target

2022-11-09 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb565e7f0c4cb: Dont try to create Expressions when the process is running. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137684/new/

[Lldb-commits] [PATCH] D137684: Make sure we are stopped before we try to install functions into the target

2022-11-09 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me, I like all of the added error messages in `FunctionCaller::WriteFunctionWrapper` in particular. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137684: Make sure we are stopped before we try to install functions into the target

2022-11-08 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda, labath, clayborg. Herald added a subscriber: kristof.beyls. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It's