Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

2015-10-20 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. Looks reasonable http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

2015-10-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good to me. Wait for Enrico to OK as well. http://reviews.llvm.org/D13836 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

2015-10-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Greg, Enrico, anyone have a chance to take a look at this? I think it's probably just a rubber stamp but rather err on the side of caution. http://reviews.llvm.org/D13836 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D13836: Fix write-after-close of file descriptor in ScriptInterpreterPython

2015-10-16 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, granata.enrico. zturner added a subscriber: lldb-commits. When we acquire the GIL with `Locker`, we save off the current stdio handles, redirect them, and when we release the GIL we put the old handles back. This triggers a