Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Daniel Berlin via lldb-commits
dberlin added a comment. LGTM from a license perspective. It doesn't impose any interesting obligations. http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Yea, I actually did something very similar to that. Check out http://reviews.llvm.org/D13906 http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. All that aside, LGTM. http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D13880#271483, @tfiala wrote: > In http://reviews.llvm.org/D13880#270742, @zturner wrote: > > > Todd, do you have any good ideas on how to organize this and make it play > > nicely with python's module / package system? `dotest` is just an > >

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Todd Fiala via lldb-commits
tfiala added a comment. In http://reviews.llvm.org/D13880#270742, @zturner wrote: > Todd, do you have any good ideas on how to organize this and make it play > nicely with python's module / package system? `dotest` is just an arbitrary > script under lldb/test and is not part of any installed

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Greg, do you have any concerns here? http://reviews.llvm.org/D13880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-19 Thread Zachary Turner via lldb-commits
zturner added a comment. Todd, do you have any good ideas on how to organize this and make it play nicely with python's module / package system? `dotest` is just an arbitrary script under lldb/test and is not part of any installed package or anything. At the same time, third party code needs

[Lldb-commits] [PATCH] D13880: Create an lldb/third_party folder, and add Python module 'six' to it.

2015-10-19 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added reviewers: tfiala, clayborg, dberlin. zturner added a subscriber: lldb-commits. `six` is a Python module licensed under MIT which provides a compatibility layer between Python 2 and Python 3. You can read about it at the project's homepage, here. ht