Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Ewan Crawford via lldb-commits
EwanCrawford added a comment. Thanks for spotting, comitted a quick fix Repository: rL LLVM http://reviews.llvm.org/D13903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. Hi, you seem to have an out-of-bounds access here: /lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp:1629:5: warning: array index 3 is past the end of the array (which contains 3 elements)

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-21 Thread Ewan Crawford via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL250886: [RenderScript] New commands to save/load RS allocations to file. (authored by EwanCrawford). Changed prior to commit: http://reviews.llvm.org/D13903?vs=37889=37972#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-20 Thread Greg Clayton via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Going forward there is no real need to review any new commands that only exist in the renderscript source files or plug-ins. If you change any code outside of the the

[Lldb-commits] [PATCH] D13903: [RenderScript] New commands to save/load RS allocations to file.

2015-10-20 Thread Ewan Crawford via lldb-commits
EwanCrawford created this revision. EwanCrawford added reviewers: clayborg, jingham. EwanCrawford added subscribers: lldb-commits, domipheus. EwanCrawford set the repository for this revision to rL LLVM. Patch adds command 'language renderscript allocation save' to store the contents of an