[Lldb-commits] [PATCH] D139082: [lldb][Module] Document ModuleList::ForEach and assert nullness

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently all callsites already assume the pointer is non-null. This patch just

[Lldb-commits] [PATCH] D139082: [lldb][Module] Document ModuleList::ForEach and assert nullness

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. If we assert non-null, why still pass a shared pointer? Could we have the lambda take a `Module &`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D139082: [lldb][Module] Document ModuleList::ForEach and assert nullness

Michael137 added a comment. In D139082#3965316 , @aprantl wrote: > If we assert non-null, why still pass a shared pointer? Could we have the > lambda take a `Module &`? I took a stab at changing it to pass a reference but turns out there's several plac

[Lldb-commits] [PATCH] D139082: [lldb][Module] Document ModuleList::ForEach and assert nullness

This revision was automatically updated to reflect the committed changes. Closed by commit rG83599000e1f4: [lldb][Module] Document ModuleList::ForEach and assert nullness (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139082/