[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG5941858efdca: [lldb][Module][NFC] Add ModuleList::AnyOf (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139083/new/

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/ModuleList.cpp:1079 +bool ModuleList::AnyOf( +std::function const ) +const { module Repository: rG LLVM

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

Michael137 updated this revision to Diff 479444. Michael137 added a comment. - Reference insstead of `shared_ptr` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139083/new/ https://reviews.llvm.org/D139083 Files:

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

Michael137 added a comment. In D139083#3964612 , @aprantl wrote: > This is definitely useful — I just have one question: Isn't ForEach a special > case of AnyOf? Could we implement on in terms of the other? Yup it is. But it looked a bit too clever and

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

Michael137 added inline comments. Comment at: lldb/include/lldb/Core/ModuleList.h:480 + /// This function is thread-safe. + bool AnyOf(std::function const + ) const; aprantl wrote: > Why not `std::function` ? Unfortunately a lot of APIs of

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

aprantl added a comment. This is definitely useful — I just have one question: Isn't ForEach a special case of AnyOf? Could we implement on in terms of the other? Comment at: lldb/include/lldb/Core/ModuleList.h:480 + /// This function is thread-safe. + bool

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

Michael137 added a comment. I suppose I could just make ForEach return a boolean instead of breaking. Could then re-use that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139083/new/ https://reviews.llvm.org/D139083

[Lldb-commits] [PATCH] D139083: [lldb][Module][NFC] Add ModuleList::AnyOf

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139083 Files: