jasonmolenda updated this revision to Diff 538253.
jasonmolenda added a comment.
Update the patch to address the failures we were hitting on the Intel macOS
10.15 CI bot. In addition to lldb_notifier_function, look for
"gdb_notifier_function" which is what it was called back in macOS 10.15. Re
jasonmolenda updated this revision to Diff 537942.
jasonmolenda added a comment.
Herald added a subscriber: wangpc.
After reverting to avoid CI bot failures on macos intel, this is an updated
patch that (1) corrects the binary image count size, (2) allows for a fallback
if it can't find the noti
This revision was automatically updated to reflect the committed changes.
Closed by commit rG624813a4f41c: Change the dyld notification function that
lldb puts a breakpoint in (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
jasonmolenda updated this revision to Diff 536492.
jasonmolenda added a comment.
Update patch to address Jim and Jonas' feedback, most importantly report a
warning if we can't read one of the mach-o binary addresses that dyld is
telling us are being added/removed.
Repository:
rG LLVM Github
JDevlieghere added inline comments.
Comment at:
lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:307-308
+
+int addr_size =
+process->GetTarget().GetArchitecture().GetAddressByteSize();
for (uint64_t i = 0; i < image_i
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
This makes sense. I think you should at least log if you can't read the memory
dyld told you was where the image info should be. Seems like this is the sort
of thing that shouldn't happen,
jasonmolenda added a comment.
oops, slight misstatement from not reading the patch when I wrote the
description. The function we currently use has an array of uint64_t's, the one
I am switching to is given an array of dyld_image_info objects, the first
element has the ptrsize address of the ma
jasonmolenda created this revision.
jasonmolenda added reviewers: jingham, JDevlieghere.
jasonmolenda added a project: LLDB.
Herald added a subscriber: kristof.beyls.
Herald added a project: All.
jasonmolenda requested review of this revision.
Herald added a subscriber: lldb-commits.
Darwin's dyna
