[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 created this revision. lh03061238 added reviewers: SixWeining, wangleiat, xen0n, xry111, MaskRay, DavidSpickett, seehearfeel. Herald added a subscriber: StephenFan. Herald added a project: All. lh03061238 requested review of this revision. Herald added a project: LLDB. Herald added a su

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining added a comment. 1. Does the directory `lldb/source/Plugins/Instruction/LoongArch/` target both `LoongArch64` and `LoongArch32`? 2. Will you handle floating pointer branching instructions `bceqz` and `bcnez` in future? Comment at: lldb/source/Plugins/Instruction/L

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added a comment. In D139833#3990635 , @SixWeining wrote: > 1. Does the directory `lldb/source/Plugins/Instruction/LoongArch/` target > both `LoongArch64` and `LoongArch32`? Yes, both LoongArch64 and LoongArch32 are supported in EmulateInstr

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:205 +bool EmulateInstructionLoongArch::EmulateBEQZ(uint32_t inst) { + uint64_t next_pc, imm_sign_extend; + bool success = false; SixWeining

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 updated this revision to Diff 482790. lh03061238 edited the summary of this revision. lh03061238 added a comment. (1) distinguish between LoongArch64 and LoongArch32 operations in EmulateInstructionLoongArch (2) check the return values of some functions CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added a comment. Is the further work in the commit message work you intended to include in this patch? I appreciate the status update might be useful for some but commit messages are for describing what's in a commit (among other things). If you think people might wrongly assume t

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This is all very repetitive, but that's to be expected. Whatever you can do to reduce boilerplate in future patches would be great. For example, can 32 and 64 bit variants of som

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.cpp:287 + uint32_t rj = Bits32(inst, 9, 5); + uint64_t rj_val; + uint64_t pc = ReadPC(&success); I would declare this where it is assigned.

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

SixWeining accepted this revision. SixWeining added a comment. LGTM from the LoongArch side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139833/new/ https://reviews.llvm.org/D139833 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

lh03061238 added a comment. In D139833#3997386 , @DavidSpickett wrote: > Is the further work in the commit message work you intended to include in > this patch? I appreciate the status update might be useful for some but > commit messages are for descr

[Lldb-commits] [PATCH] D139833: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rGeafe2d4cf17b: [LLDB][LoongArch] Add branch instructions for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION