serge-sans-paille created this revision.
serge-sans-paille added a reviewer: nikic.
Herald added subscribers: steakhal, pmatos, asb, jhenderson, abrachet, ormris,
martong, phosek, kadircet, arphaman, steven_wu, hiraditya, arichardson, sbc100,
emaste.
Herald added a reviewer: JDevlieghere.
Herald
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470
const char *const *Prefixes[DriverID::LastOption] = {nullptr};
-#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE;
+#define PREFIX(NAME, VALUE) static constexpr llv
serge-sans-paille added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470
const char *const *Prefixes[DriverID::LastOption] = {nullptr};
-#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE;
+#define PREFIX(NAME, VALUE) static cons
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:470
const char *const *Prefixes[DriverID::LastOption] = {nullptr};
-#define PREFIX(NAME, VALUE) static const char *const NAME[] = VALUE;
+#define PREFIX(NAME, VALUE) static constexpr llv
steakhal added a comment.
The `StaticAnalyzer` portion looks good to me AFAICT.
Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39
ento::CallDescription::CallDescription(CallDescriptionFlags Flags,
- ArrayRef QualifiedName,
+
serge-sans-paille updated this revision to Diff 482825.
serge-sans-paille added a comment.
Make `Prefixes` an array of StringRef too
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139881/new/
https://reviews.llvm.org/D139881
Files:
clang-tools-extra/clangd/CompileCommands.cpp
clang/
serge-sans-paille marked 4 inline comments as done.
serge-sans-paille added a comment.
New version passes `ninja check` with clang, clang-tools-extra and lld.
Comment at: clang/lib/StaticAnalyzer/Core/CallDescription.cpp:39
ento::CallDescription::CallDescription(CallDescriptio
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:469
// Also grab prefixes for each option, these are not fully exposed.
-const char *const *Prefixes[DriverID::LastOption] = {nullptr};
-#define PREFIX(NAME, VALUE) static const char
nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D139881/new/
https://reviews.llvm.org/D139881
___
lldb-commits mailing list
lldb-commits@l
