[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2023-01-26 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. Not needed anymore due to simpler implementation at https://reviews.llvm.org/D141828 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140262/new/ https://reviews.llvm.org/D140262

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2022-12-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; Michael137 wrote: > Michael137 wrote: > > labath wrote: > > > This may depend on

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2022-12-19 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; Michael137 wrote: > labath wrote: > > This may depend on where you're going

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2022-12-19 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +}; labath wrote: > This may depend on where you're going with this, but right

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2022-12-19 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h:334 +struct ArgumentMetadata { + char const *const name = nullptr; +};

[Lldb-commits] [PATCH] D140262: [lldb][TypeSystemClang][NFC] Introduce TemplateParameterInfos::ArgumentMetadata

2022-12-17 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: aprantl, labath. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch creates a new aggregate type that holds information about a