This revision was automatically updated to reflect the committed changes.
Closed by commit rG9e84e038447e: [lldb] Allow configuring on Windows with
python interpreter within a junction (authored by zero9178).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
clayborg accepted this revision.
clayborg added a comment.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141042/new/
https://reviews.llvm.org/D141042
___
lldb-commits mailing list
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Looks reasonable to me.
@lawrence_danna do you happen to remember why you wrote:
exe = os.path.join(os.path.realpath(os.path.dirname(exe)), os.readlink(exe))
instead of
exe
zero9178 created this revision.
zero9178 added reviewers: JDevlieghere, lawrence_danna, clayborg, labath,
jingham.
Herald added a project: All.
zero9178 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The current implementation nicely
