[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib created this revision. mib added reviewers: JDevlieghere, bulbazord, LLDB. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch removes the `-py3` swig flag, to generate python3 bindings since it has

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. In what version of SWIG was this deprecated? We officially support SWIG 3 and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so then this is fine

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added a comment. Looks like -py3 was marked deprecated and no-effect in 4.1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142245/new/ https://reviews.llvm.org/D142245 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added a comment. In D142245#4069960 , @JDevlieghere wrote: > In what version of SWIG was this deprecated? We officially support SWIG 3 > and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so > then this is fine, otherwise w

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added a comment. In D142245#4070002 , @kastiglione wrote: > Looks like -py3 was marked deprecated and no-effect in 4.1. Thanks for looking it up Dave :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

kastiglione added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:11 -c++ -shadow -python Note that `-shadow` has been deprecated since 2002 and is on by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D142245: [lldb/swig] Remove deprecated `-py3` flag to generate bindings

mib added inline comments. Comment at: lldb/bindings/python/CMakeLists.txt:11 -c++ -shadow -python kastiglione wrote: > Note that `-shadow` has been deprecated since 2002 and is on by default. I guess that this is a leftover from the time we