[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

2023-03-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo the else-after-return. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1949-1950 +new StructuredPythonOb

[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

2023-03-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Committed as: 9093f3c39b8fa8ef836c627e1db329cd7349e9bb . I forgot to include the "differential revision" line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D142260: Actually report an error when `command script add` is passed a non-existent class

2023-01-20 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before we were returning a SP with an invalid PythonObject, but the calling code wan