[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

2023-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I wouldn't exactly use the word happy, but I also don't have the time to come up with an alternative proposal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

2023-01-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Cool, I like how this sidesteps having to go through the plugin instantiation mechanism. LGTM if Pavel's happy. Comment at: lldb/include/lldb/Interpreter/OptionGroupPlatform.h:19 +class CommandObjectPlatformSelect; // PlatformOptionGroup --

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

2023-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. Friendly reminding @labath @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142266/new/ https://reviews.llvm.org/D142266 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

2023-01-20 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: JDevlieghere, labath. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a less intrusive implementation of 2d53527