[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-03-06 Thread David Stenberg via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG98c3dc3fa748: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines (authored by dstenb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-03-06 Thread David Stenberg via Phabricator via lldb-commits
dstenb added a comment. In D142552#4083939 , @clayborg wrote: > As long as there are no regressions in the test suite this looks good to me Thanks, and sorry for the delay with landing this! I have ran check-lldb. I will land this shortly.

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-01-26 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. As long as there are no regressions in the test suite this looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142552/new/

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-01-25 Thread David Stenberg via Phabricator via lldb-commits
dstenb added a comment. First time looking at LLDB, so I had trouble finding a suitable way to create a reproducer for this. I would be happy to change to another type of lit test if that is more suitable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D142552: [lldb] Make GetDIENamesAndRanges() allow 0-valued decl and call lines

2023-01-25 Thread David Stenberg via Phabricator via lldb-commits
dstenb created this revision. dstenb added reviewers: jasonmolenda, clayborg, aeubanks, ayermolo. dstenb added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. Herald added a project: All. dstenb requested review of this revision. Herald added a reviewer: