labath added a comment.
I'm sorry Omair, my comment was meant for Jorge, not you. `@skipIfXml` is not
the right decorator here, although it will probably kinda fix the failure
(because the bot does not have xml support either). I *think* the compressed
section support is controlled by presence
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbde5d31e96f5: Revert "Revert "[lldb] Make
SBSection::GetSectionData call Section… (authored by omjavaid).
Changed prior to commit:
https://reviews.llvm.org/D142672?vs=492839&id=493267#toc
Repository:
labath added a comment.
I'm pretty sure that's because that bot builds without zlib support. You'll
need to add something like `@skipIfXmlSupportMissing` to this test (I think we
don't have a decorator for zlib now, so you'll probably need to add one).
While you're at it, you might as well slap
omjavaid reopened this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
LLDB windows buildbots were broken by the TestSectionAPI.py test. I dont
have full context of the commit to fix it. Reverting it temporarily.
https://lab.llvm.org/buildbot/#/builders/83/bui
This revision was automatically updated to reflect the committed changes.
jgorbe marked an inline comment as done.
Closed by commit rG805600c7d573: [lldb] Make SBSection::GetSectionData call
Section::GetSectionData. (authored by jgorbe).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
jgorbe marked an inline comment as done.
jgorbe added inline comments.
Comment at: lldb/source/API/SBSection.cpp:187-189
+DataExtractorSP result_data_sp =
+std::make_shared(section_data, offset, size);
+sb_data.SetOpaque(result_data_sp);
dblaikie
jgorbe updated this revision to Diff 492602.
jgorbe added a comment.
Addressing review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142672/new/
https://reviews.llvm.org/D142672
Files:
lldb/source/API/SBSection.cpp
lldb/test/API/python_api/section/TestSectionAPI.py
lldb/
dblaikie added inline comments.
Comment at: lldb/source/API/SBSection.cpp:187-189
+DataExtractorSP result_data_sp =
+std::make_shared(section_data, offset, size);
+sb_data.SetOpaque(result_data_sp);
Probably either use `std::move` when passing `re
jgorbe created this revision.
jgorbe added a reviewer: labath.
jgorbe added a project: LLDB.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
jgorbe requested review of this revision.
`SBSection::GetSectionData` and `Section::GetSectionData` are
implemented differently, and th
