kastiglione created this revision.
kastiglione added reviewers: jingham, Michael137, augusto2112, aprantl.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Adopt `expression`'s options in `dwim-print`
kastiglione updated this revision to Diff 497720.
kastiglione added a comment.
Some `expression` flags force the use of expression evaluation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144114/new/
https://reviews.llvm.org/D144114
Files:
lldb
kastiglione updated this revision to Diff 497723.
kastiglione added a comment.
Use `expression`'s "description verbosity"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144114/new/
https://reviews.llvm.org/D144114
Files:
lldb/source/Commands/Comm
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Conceptually, I think this looks good to me.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:68
// First, try `expr` as the name of a frame variable.
- if (
kastiglione updated this revision to Diff 498054.
kastiglione added a comment.
Use only a subset of expression flags.
Specifically, don't expose `--debug`/`-g` or `--top-level`/`-p`. These, unlike
the other `expression` flags, the semantics of these flags would seem to force
`expression` evaluati
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:68
// First, try `expr` as the name of a frame variable.
- if (StackFrame *frame = m_exe_ctx.GetFramePtr()) {
-auto valobj_sp = frame->FindVariable(ConstString(expr));
-if (
aprantl accepted this revision.
aprantl added a comment.
Yeah, this is better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144114/new/
https://reviews.llvm.org/D144114
___
lldb-commits mailing list
lld
jingham requested changes to this revision.
jingham added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119
}
+
+llvm::ArrayRef
There's a version of Append that lets you exclude and re
kastiglione updated this revision to Diff 498241.
kastiglione added a comment.
Add and adopt new variation of OptionGroupOptions::Append
Pass OptionGroupValueObjectDisplay to GetEvalateExpressionOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
kastiglione updated this revision to Diff 498245.
kastiglione added a comment.
- Fix bug in new OptionGroupOptions::Append
- Fix typo in GetEvaluateExpressionOptions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144114/new/
https://reviews.llvm.org
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119
}
+
+llvm::ArrayRef
jingham wrote:
> There's a version of Append that lets you exclud
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:119
}
+
+llvm::ArrayRef
jingham wrote:
> jingham wrote:
> > There's a version of Append that lets you exclude and remap option sets.
> > This seems like a finer-grai
This revision was automatically updated to reflect the committed changes.
Closed by commit rG920b46e108b2: [lldb] Add expression command options in
dwim-print (authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144114/new/
https
13 matches
Mail list logo