[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

2023-04-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett resigned from this revision. DavidSpickett added a comment. This is probably an obvious change, but I have no experience with this area so I don't feel comfortable approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

2023-04-20 Thread Pavel Kosov via Phabricator via lldb-commits
kpdev42 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144390/new/ https://reviews.llvm.org/D144390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

2023-03-13 Thread Pavel Kosov via Phabricator via lldb-commits
kpdev42 added a comment. In D144390#4138869 , @DavidSpickett wrote: > What is the practical impact of the bug you are fixing? > > I guess it is something like if you set signal handling info, then attach to > something, that info is not used. Until you

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

2023-02-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. What is the practical impact of the bug you are fixing? I guess it is something like if you set signal handling info, then attach to something, that info is not used. Until you set it again, then it'll be sent and used. Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D144390: [lldb] Send QPassSignals packet on attach, and at start for remote platforms

2023-02-20 Thread Pavel Kosov via Phabricator via lldb-commits
kpdev42 created this revision. kpdev42 added reviewers: clayborg, davide, k8stone, DavidSpickett. kpdev42 added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. kpdev42 requested review of this revision. Herald added a subscriber: lldb-commits. Before this pat