[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib updated this revision to Diff 500349. mib retitled this revision from "[lldb] Fix {break,watch}point command function stopping behavior" to "[lldb] Fix {break,watch}point command function stopping behaviour". mib edited the summary of this revision. mib added a comment. The third implementat

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); Why do

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

bulbazord added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); delcyp

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

jingham added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); bulbazor

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib updated this revision to Diff 500975. mib added a comment. Rename `is_oneliner` flag to `is_callback` and swap the logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/sou

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher accepted this revision. delcypher added a comment. @mib Thanks for working on this. LGTM (with very minor nits), but you should probably wait for someone who works on LLDB more frequently than me to give you the ok. Comment at: lldb/source/Plugins/ScriptInterpreter

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib updated this revision to Diff 501240. mib marked an inline comment as done. mib added a comment. Address @delcypher comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

bulbazord accepted this revision. bulbazord added a comment. LGTM thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9fce1fed6d: [lldb] Fix {break,watch}point command function stopp

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

JDevlieghere added a comment. You're passing `is_callback` by value so the `const` is close to redundant. I think there's an "Effective C++" chapter dedicated to this. LLVM is pretty conservative in marking this as `const` and while LLDB uses it a bit more this isn't common at all. The current

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

kparzysz added a comment. This broke Lua support: In file included from /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9: /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.h:95:68: error: non-virtual member function marked 'o

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added a comment. In D144688#4165144 , @kparzysz wrote: > This broke Lua support: > > In file included from > /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9: > > /w/src/llvm.org/lldb/source/Plugins/Scri

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib added a comment. In D144688#4165152 , @delcypher wrote: > In D144688#4165144 , @kparzysz > wrote: > >> This broke Lua support: >> >> In file included from >> /w/src/llvm.org/lldb/source/Plugins/ScriptInter

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

mib added a comment. @kparzysz I landed the fix in ab81fc29d9f7a8f8807293fc987f68f9ccf42259 . Let me know if you still have some issues. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

kparzysz added a comment. Looks good. Thanks for the quick fix @mib! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144688/new/ https://reviews.llvm.org/D144688 ___ lldb-commits mailing list lldb-commits