[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

2023-03-02 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, jingham, labath, werat. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-comm

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

2023-03-02 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. So, one could say that (right now) this patch is NFC for end-users, because `dwim-print` supports all use-cases that the old `p` alias supported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/ https://reviews.ll

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

2023-03-02 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. So from my point of view, this is a good path forward, so assuming that the other reviewers agree, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

2023-03-06 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. > So, one could say that (right now) this patch is NFC for end-users, because > `dwim-print` supports all use-cases that the old `p` alias supported? Correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/

[Lldb-commits] [PATCH] D145189: [lldb] Redefine p alias to dwim-print command

2023-03-06 Thread Dave Lee via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa00801d94b02: [lldb] Redefine p alias to dwim-print command (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145189/new/ https://rev