DavidSpickett created this revision.
Herald added a subscriber: mgrang.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This teaches ProcessGDBRemote to look for "flags" nodes
in the target XML tha
DavidSpickett added a comment.
Tests are added in https://reviews.llvm.org/D145580, because they use the
formatting code added there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/new/
https://reviews.llvm.org/D145574
_
DavidSpickett updated this revision to Diff 503376.
DavidSpickett added a comment.
Use StringRef instead of std::string.
Though an empty StringRef is morally equivalent
to optional, I've stuck with optional to keep the code
looking consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINC
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
This looks good to me.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4066
+"ProcessGDBRemote::ParseFlags Invalid start %
DavidSpickett updated this revision to Diff 504106.
DavidSpickett added a comment.
Remove use of type attribute on flags. We will recognise it as valid,
but do nothing with it as it's not needed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/
DavidSpickett updated this revision to Diff 504107.
DavidSpickett added a comment.
Correct printf for `unsigned`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/new/
https://reviews.llvm.org/D145574
Files:
lldb/include/lldb/Target/DynamicR
DavidSpickett added a comment.
The big assumption here is that the GDB process lasts longer than the higher
level debug session does. I am keeping a map of register name to unique pointer
in the GDB process, then giving out raw pointers to the higher level commands.
The higher level is destroye
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053
+ // appears once, so we don't have to handle that here.
+ if (attr_name == "name") {
+LLDB_LOGF(log,
Do you think that using a `Str
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053
+ // appears once, so we don't have to handle that here.
+ if (attr_name == "name") {
+LLDB_LOGF(log,
JDevlieghere wrote:
> Do you
DavidSpickett updated this revision to Diff 506903.
DavidSpickett added a comment.
Use LOG instead of LOGF.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/new/
https://reviews.llvm.org/D145574
Files:
lldb/include/lldb/Target/DynamicRegiste
JDevlieghere accepted this revision.
JDevlieghere added inline comments.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4053
+ // appears once, so we don't have to handle that here.
+ if (attr_name == "name") {
+LLDB_LOGF(log,
--
DavidSpickett updated this revision to Diff 512702.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/new/
https://reviews.llvm.org/D145574
Files:
lldb/include/lldb/Target/DynamicRegisterInfo.h
lldb/inc
This revision was automatically updated to reflect the committed changes.
Closed by commit rG54981bb75d37: [lldb] Read register fields from target XML
(authored by DavidSpickett).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145574/new/
https://rev
MaskRay added inline comments.
Comment at: lldb/include/lldb/lldb-private-types.h:14
+#include "lldb/Target/RegisterFlags.h"
#include "lldb/lldb-private.h"
Is there a library layering violation?
I assume that `lldb/Target/*.h` files depend on
`lldb/include/l
DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.
Comment at: lldb/include/lldb/lldb-private-types.h:14
+#include "lldb/Target/RegisterFlags.h"
#include "lldb/lldb-private.h"
MaskRay wrote:
> Is there a library layering viola
15 matches
Mail list logo