[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a subscriber: Jake-Egan. Michael137 added a comment. Oh looks like @Jake-Egan already did Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. Looks like `gmodules` isn't supported on AIX (based on other tests that use `-dwarf-ext-refs`. So I'll just disable the new tests Thanks for notifying @aaron.ballman , email notifications got lost in the inbox Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aaron.ballman added a comment. The changes in this patch seem to have caused https://lab.llvm.org/buildbot/#/builders/clang-ppc64-aix to go down for the past 4 days -- can you revert and investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-preferred-name-alias.cpp:6 +// RUN: -fmodules -mllvm -debug-only=pchcontainer -x c++ \ +// RUN: -I %S/Inputs %s &> %t.ll +// RUN: cat %t.ll | FileCheck %s I guess it made difficult to

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG711a64412749: [clang][DebugInfo] Emit DW_AT_type of preferred name if available (authored by Michael137). Repository:

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. I'll submit later today then if nobody has any other objections Will add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. > @probinson Sounds like Sony's solution also changes the `DW_AT_type` to a > non-canonical form. Do you still have concerns with the direction of this > patch? Would it cause any problems for you downstream? Sorry for the late reply. Looking at the patch I don't

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4220124 , @wolfgangp wrote: > In D145803#4219894 , @probinson > wrote: > >> This is pretty different from the "always desugar to the canonical type" >> habit that has

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > dblaikie wrote: > > Michael137 wrote: > > > probinson wrote: > > > > This doesn't become `Foo` ? > > > The name stays as `Foo>` but

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 marked an inline comment as not done. Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + dblaikie wrote: > Michael137 wrote: > > probinson wrote: > > > This doesn't become `Foo` ? > > The

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

dblaikie added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + Michael137 wrote: > probinson wrote: > > This doesn't become `Foo` ? > The name stays as `Foo>` but the type of the template parameter > becomes

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508562. Michael137 added a comment. - Refine tests: - Check for type of template parameter - Add test for chained typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/test/CodeGen/preferred_name.cpp:49 + +Foo> varFooInt; + probinson wrote: > This doesn't become `Foo` ? The name stays as `Foo>` but the type of the template parameter becomes `BarInt`. So the dwarf would

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

wolfgangp added a comment. In D145803#4219894 , @probinson wrote: > This is pretty different from the "always desugar to the canonical type" > habit that has always been in place. Sony has done some downstream things to > try to work around that in the

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

probinson added subscribers: wolfgangp, probinson. probinson added a comment. This is pretty different from the "always desugar to the canonical type" habit that has always been in place. Sony has done some downstream things to try to work around that in the past. @wolfgangp will remember it

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; aprantl wrote: > I'm curious if this works if we encounter a forward declaration,

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2640 if (!D || !D->isCompleteDefinition()) -return FwdDecl; +return {FwdDecl, nullptr}; I'm curious if this works if we encounter a forward declaration, early exit here,

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 506588. Michael137 added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Fix cycle in `DIDerivedType` when we deal with forward declarations and complete explicitly via `completeClassData` (e.g., with `-gmodules`) - Add