[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-20 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added a reviewer: JDevlieghere. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldbUtility is not supposed to depend on anything else in lldb. Let's enforce

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-20 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. Note that this won't stop people from performing `#include` with non-Utility files, but this marks the intent that Utility is not supposed to be using anything else in lldb. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Can we do something similar for plugins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. > Can we do something similar for plugins? Yep, I'll tackle that in a follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146473/new/ https://reviews.llvm.org/D146473 ___

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-21 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2356bf27f722: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D146473: [lldb][CMake] Enforce not letting lldbUtility link against any other lldb libs

2023-03-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D146473#4210440 , @bulbazord wrote: >> Can we do something similar for plugins? > > Yep, I'll tackle that in a follow-up. For those following along at home: D146553 Repository: rG LLVM