JDevlieghere closed this revision.
JDevlieghere added a comment.
https://reviews.llvm.org/rG75ca15fcbb2e1b3671e41f971a000c6d59f5e5ae
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146779/new/
https://reviews.llvm.org/D146779
jingham added a comment.
I fixed those two nits on submission.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146779/new/
https://reviews.llvm.org/D146779
___
lldb-commits mailing list
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:1754-1760
+if (error.Success()) {
+ command.erase(start_backtick, end_backtick -
jingham created this revision.
jingham added reviewers: JDevlieghere, bulbazord, kastiglione.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
A while back I reworked the way that backticks are handled
