This revision was automatically updated to reflect the committed changes.
Closed by commit rGd03d98b71d03: [lldb] Replace sprintf with snprintf (NFC)
(authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147246/new/
https://review
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Ship it
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147246/new/
https://reviews.llvm.org/D147246
kastiglione added a comment.
That may be better, I don't really know. I would prefer to merge this as is
(and leave a printf->formatv migration for another time).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147246/new/
https://reviews.llvm.org/D
JDevlieghere added a comment.
This looks fine, but I wonder if using `llvm::formatv` wouldn't make this a
whole lot easier?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147246/new/
https://reviews.llvm.org/D147246
___
kastiglione created this revision.
kastiglione added a reviewer: JDevlieghere.
Herald added a project: All.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
On macOS, `sprintf` is deprecated, using `snprintf` is recommended inste
