[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Adrian's and my comments addressed. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function. +

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function. + /// \param[in] generic_trampoline + /// If this function is a generic trampoline. A generic trampoline Is th

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 updated this revision to Diff 511549. augusto2112 marked 3 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147292/new/ https://reviews.llvm.org/D147292 Files: lld

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere added a comment. > Be handy to mark this abandoned when you get a chance Augusto had already abandoned it when he wrote that reply, maybe you're looking at a different patch or stale tab? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

dblaikie added a comment. In D147292#4238834 , @augusto2112 wrote: > In D147292#4238820 , @JDevlieghere > wrote: > >> There seems to be overlap in the code added in this patch and D146679 >>

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere added inline comments. Comment at: lldb/source/Core/Module.cpp:780 + bool is_trampoline = + Target::GetGlobalProperties().GetEnableTrampolineSupport() && + sc.function && sc.function->IsGenericTrampoline(); You can hoist `targe

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 added a comment. In D147292#4238820 , @JDevlieghere wrote: > There seems to be overlap in the code added in this patch and D146679 > . Does one supersede the other or is there > a dependency? If it's the la

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

JDevlieghere added a comment. There seems to be overlap in the code added in this patch and D146679 . Does one supersede the other or is there a dependency? If it's the latter you should extract that into a separate patch and make it a parent revision of this a

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support fo