[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

2023-04-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with or without the DenseMap, whichever makes the most sense. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation u

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

2023-04-07 Thread Augusto Noronha via Phabricator via lldb-commits
augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation unit. + std::unordered_map GetCompileOptions() { +std::unordered_map args; JDevlieghere wrote: > Any reason you picked `unordered

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

2023-04-10 Thread Augusto Noronha via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG19d969e340c9: [lldb] Implement SymbolFile::GetCompileOptions (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/ https://re