Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

This revision was automatically updated to reflect the committed changes. Closed by commit rL253657: Use thumb instruction set for ldb-server on android arm (authored by tberghammer). Changed prior to commit: http://reviews.llvm.org/D14816?vs=40635=40756#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

ovyalov accepted this revision. ovyalov added a comment. LGTM http://reviews.llvm.org/D14816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D14816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

omjavaid added a subscriber: omjavaid. omjavaid added a comment. -mthumb will force T32 instruction set while -marm will force A32. Best is not to use any of these flags to let the compiler decide best possible instruction set combination. http://reviews.llvm.org/D14816

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

-mthumb will force T32 instruction set while -marm will force A32. Best is not to use any of these flags to let the compiler decide best possible instruction set combination. On 19 November 2015 at 20:38, Oleksiy Vyalov via lldb-commits wrote: > ovyalov accepted

Re: [Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

tberghammer added a comment. In http://reviews.llvm.org/D14816#292929, @omjavaid wrote: > -mthumb will force T32 instruction set while -marm will force A32. > > Best is not to use any of these flags to let the compiler decide best > possible instruction set combination. I think because we

[Lldb-commits] [PATCH] D14816: Use thumb instruction set for ldb-server on android arm

tberghammer created this revision. tberghammer added reviewers: labath, ovyalov. tberghammer added a subscriber: lldb-commits. Herald added subscribers: srhines, danalbert, tberghammer, rengolin, aemerson. Use thumb instruction set for ldb-server on android arm This change reduce the size of the