This revision was automatically updated to reflect the committed changes.
Closed by commit rL253973: Disable forcing -marm (A32 instruction set) while
running testsuite on arm… (authored by omjavaid).
Changed prior to commit:
http://reviews.llvm.org/D14823?vs=40652&id=41017#toc
Repository:
r
tberghammer accepted this revision.
tberghammer added a comment.
I agree with your suggestion to make this the default config and then add a new
option where we can specify additional target specific options and then
skip/xfail tests based on that.
http://reviews.llvm.org/D14823
___
omjavaid added a comment.
I agree with you on having multiple configuration options to help identify
failures in different configurations.
What I mean is that we should keep clarity on architecture that is to use arm
or aarch32 for 32bit and aarch64 for 64bit. With that we should run tests in
tberghammer added a comment.
I agree that it can be specified by CFALGS and CXXFLAGS but we will need some
way in the test suit to xfail a test based on the instruction set and sometime
we also need different test expectations based on it. Doing these based on
C(XX)FALGS is a bit problematic so
omjavaid added a comment.
-mthumb and -marm are compiler flags so we can put these into our CXX or CFLAGS
if we need to run those configurations.
http://reviews.llvm.org/D14823
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.
tberghammer added a comment.
Can we create a setup where the test suit is capable of running in all 3 mode
(arm/thumb/mixed)?
I think we should introduce a new architecture called "arm-thumb" (open for
better name suggestions) what run the test suit in mixed mode while running the
test suit wi
omjavaid created this revision.
omjavaid added reviewers: tberghammer, clayborg.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch disables forcing -marm (A32 instruction set) while running lldb
testsuite on arm targets.
gcc uses -marm and -mthum
