[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG482a0ad5ba72: [lldb] Improve logging for process state change (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://rev

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib updated this revision to Diff 515473. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 Files: lldb/source/Target/Process.cpp Index: l

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib added a comment. In D148399#4284809 , @bulbazord wrote: > We'd go from: > > LLDB_LOGF(log, > "Process::SetPrivateState (plugin = %s, state = %s) state didn't " > "change. Ignoring...", > GetPluginName().data(), St

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

bulbazord added a comment. We'd go from: LLDB_LOGF(log, "Process::SetPrivateState (plugin = %s, state = %s) state didn't " "change. Ignoring...", GetPluginName().data(), StateAsCString(new_state)); to LLDB_LOG(log, "(plugin = %s, state = %s) state didn't

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib added a comment. In D148399#4274470 , @JDevlieghere wrote: > I think a lot of this can be simplified by using `LLDB_LOG` instead of > `LLDB_LOGF`. In D148399#4275219 , @bulbazord wrote: > +1 to what Jona

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

bulbazord added a comment. +1 to what Jonas said. `LLDB_LOG` would greatly simplify this since it puts `__FILE__` and `__func__` in each message, which is what these are doing manually. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ ht

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

JDevlieghere added a comment. I think a lot of this can be simplified by using `LLDB_LOG` instead of `LLDB_LOGF`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148399/new/ https://reviews.llvm.org/D148399 _

[Lldb-commits] [PATCH] D148399: [lldb] Improve logging for process state change (NFC)

mib created this revision. mib added reviewers: bulbazord, jingham, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch improves process state change logging messages to include to process