Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Tamas Berghammer via lldb-commits
The problem is that in PlatformNetBSD::Initialize you call Platform::SetHostPlatform unconditionally. You want to call Platform::SetHostPlatform only if we are running on NetBSD so you have to surround it with some conditional compilation (see example in PlatformLinux::Initialize) On Fri, Nov 20,

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D14844#293692, @labath wrote: > If anyone hasn't found the link yet. it's > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. > There is no mailing list but you can monitor the webpage containing all >

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. In http://reviews.llvm.org/D14844#293787, @tberghammer wrote: > The problem is that in PlatformNetBSD::Initialize you call > Platform::SetHostPlatform unconditionally. You want to > call Platform::SetHostPlatform only if we are running on NetBSD so you have > to

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-20 Thread Pavel Labath via lldb-commits
labath added a subscriber: labath. labath added a comment. If anyone hasn't found the link yet. it's http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/8653. There is no mailing list but you can monitor the webpage containing all builtbots. They are not sending out blame

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-19 Thread Siva Chandra via lldb-commits
sivachandra added a comment. Actually, I do not have time today to do a better job with digging and have to resort to reverting. Repository: rL LLVM http://reviews.llvm.org/D14844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-19 Thread Kamil Rytarowski via lldb-commits
krytarowski added a comment. Could you please reference a hyperlink to the breakage? Have we got some mailing list to monitor it? Jumping over logs in waterfall isn't much convenient. Repository: rL LLVM http://reviews.llvm.org/D14844 ___

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-19 Thread Siva Chandra via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL253615: Revert "Plug-in PlatformNetBSD initializer and terminator" (authored by sivachandra). Changed prior to commit: http://reviews.llvm.org/D14844?vs=40708=40710#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-19 Thread Siva Chandra via lldb-commits
sivachandra created this revision. sivachandra added reviewers: emaste, krytarowski. sivachandra added a subscriber: lldb-commits. This reverts commit 2354cd73101e58540b8b39783df462d06023309f as it introduced a bunch regressions on the linux bot. http://reviews.llvm.org/D14844 Files:

Re: [Lldb-commits] [PATCH] D14844: Revert "Plug-in PlatformNetBSD initializer and terminator"

2015-11-19 Thread Zachary Turner via lldb-commits
Agreed, when a CL is reverted due to a buildbot breakage, please include a link to the failing bot in the commit message of the revert. On Thu, Nov 19, 2015 at 5:57 PM Kamil Rytarowski via lldb-commits < lldb-commits@lists.llvm.org> wrote: > krytarowski added a comment. > > Could you please