Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2016-01-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. Can this be closed out? http://reviews.llvm.org/D14896 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-12-06 Thread Todd Fiala via lldb-commits
tfiala accepted this revision. tfiala added a comment. This revision is now accepted and ready to land. Basic idea looks fine. (I saw you put this in not long after, but I'm finally getting to look at the actual review). I'm not sure if you're intending to cover all the use cases of the generat

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-21 Thread Todd Fiala via lldb-commits
tfiala added a comment. Nice, I'm looking forward to looking at this in depth. I'm out (not around a computer) until after Thanksgiving. I may be a little laggy on feedback. http://reviews.llvm.org/D14896 ___ lldb-commits mailing list lldb-commit

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner added a comment. Note: I was wrong in my initial post, you can't actually generate multiple language bindings in a single invocation. So the second patchset loops over the language list and invokes swig multiple times. Note that we have some occurrences of `%pythoncode` in the swig fil

Re: [Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner updated this revision to Diff 40852. zturner added a comment. Fixed a few minor issues http://reviews.llvm.org/D14896 Files: scripts/swig_bot.py scripts/swig_bot_lib/__init__.py scripts/swig_bot_lib/client.py scripts/swig_bot_lib/local.py scripts/swig_bot_lib/server.py Index:

[Lldb-commits] [PATCH] D14896: Local path implementation of swig-bot.py

2015-11-20 Thread Zachary Turner via lldb-commits
zturner created this revision. zturner added a reviewer: tfiala. zturner added a subscriber: lldb-commits. This version supports local generation only. It's intentionally stupid, and does not support any kind of dependency checking. If you run the script, it's going to call SWIG. Per