[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-07-20 Thread Tom Tromey via Phabricator via lldb-commits
tom.tromey added a comment. > Apart from just implementing type system itself (which is much bigger scope > than this change) there are other non-trivial issues: > > 1. There is no "compiler-as-a-service" in Rust so getting expressions to work > is non-trivial. An interpreter of some sort needs

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-07-21 Thread Vladimir Makaev via Phabricator via lldb-commits
VladimirMakaev marked an inline comment as done. VladimirMakaev added a comment. In D149213#4520309 , @tom.tromey wrote: >> Apart from just implementing type system itself (which is much bigger scope >> than this change) there are other non-trivial issu

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-07-21 Thread J. Ryan Stinnett via Phabricator via lldb-commits
jryans added a comment. In D149213#4491889 , @VladimirMakaev wrote: > I think there was an attempt in the past to build TypeSystemRust. Rust > Project had a fork of LLDB with this implemented by Tom Tromey and CodeLLDB > maintainer(vadimcn) has one. Bo

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-08-04 Thread Vladimir Makaev via Phabricator via lldb-commits
VladimirMakaev added a comment. I don't have commit access to the repo. Since this was accepted can somebody commit this to the repo? CC @clayborg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 ___

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-08-17 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I fixed a typo in this to get the Windows build going again: https://github.com/llvm/llvm-project/commit/f8d1209f966ccd1dd0a19f3acef0871bf8fc3c94 I assume it's a typo, not an attempt to use what seems to have been a NetBSD type at one point. Repository: rG LLV

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-08-17 Thread Vladimir Makaev via Phabricator via lldb-commits
VladimirMakaev added a comment. Thanks @DavidSpickett for fixing this. I did not intend to use that type. Any number of that size would work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149213/new/ https://reviews.llvm.org/D149213 _

Re: [Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

2023-07-21 Thread Jim Ingham via lldb-commits
> On Jul 21, 2023, at 9:52 AM, J. Ryan Stinnett via Phabricator via > lldb-commits wrote: > > jryans added a comment. > > In D149213#4491889 , > @VladimirMakaev wrote: > >> I think there was an attempt in the past to build TypeSystemRust. Rust >> P