[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

2023-04-26 Thread Alex Langford via Phabricator via lldb-commits
bulbazord updated this revision to Diff 517309. bulbazord added a comment. Remove code instead of attempting to fix things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149284/new/ https://reviews.llvm.org/D149284 Files:

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

2023-04-26 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D149284#4299933 , @jasonmolenda wrote: > I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have > no idea what it is for. I know of no such prefix related to kernel > debugging. Let's remove it

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

2023-04-26 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. I added this in 2016 via 243bd763ecad466fac748b565ea52c661107684d and I have no idea what it is for. I know of no such prefix related to kernel debugging. Let's remove it instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D149284: [lldb] Fix finding .Bundle directories in PlatformDarwinKernel

2023-04-26 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added a reviewer: jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. FileSpec::GetFileNameExtension returns a string where the first character is