dyung added a comment.
I’m also seeing this fail on 2 buildbots:
https://lab.llvm.org/buildbot/#/builders/217/builds/20568
https://lab.llvm.org/buildbot/#/builders/243/builds/5576
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149397/new/
https://r
cmtice added a comment.
I'm seeing the same build failures reported by mgorny. Would you consider
reverting this patch until you can fix it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149397/new/
https://reviews.llvm.org/D149397
__
mgorny added a comment.
This change broke building with GCC:
samu: job failed: /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DHAVE_ROUND
-D_DEBUG -D_GLIBCXX_ASSERTIONS -D_LIBCPP_ENABLE_ASSERTIONS
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-I/var/tmp/portage/dev-util
This revision was automatically updated to reflect the committed changes.
Closed by commit rGade3c6a6a88e: Host: generalise `GetXcodeSDKPath` (authored
by compnerd).
Changed prior to commit:
https://reviews.llvm.org/D149397?vs=517764&id=517959#toc
Repository:
rG LLVM Github Monorepo
CHANGES
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks Saleem!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149397/new/
https://reviews.llvm.org/D149397
___
compnerd created this revision.
compnerd added reviewers: JDevlieghere, kastiglione, aprantl.
compnerd added a project: LLDB.
Herald added a project: All.
compnerd requested review of this revision.
This generalises the `GetXcodeSDKPath` hook to a `GetSDKRoot` path which
will be re-used for the Wi
