This revision was automatically updated to reflect the committed changes.
Closed by commit rL255016: Modify "platform connect" to connect to processes as
well (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D14952?vs=42063&id=42170#toc
Repository:
rL LLVM
http://
tberghammer added inline comments.
Comment at: source/Commands/CommandObjectPlatform.cpp:414-419
@@ -413,1 +413,8 @@
+
+
platform_sp->ConnectToWaitingProcesses(m_interpreter.GetDebugger(), error);
+if (error.Fail())
+{
+
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, just check me inline comment and make changes if you think you need
to.
Comment at: source/Commands/CommandObjectPlatform.cpp:414-419
@@ -413,1 +413,8 @@
+
+
tberghammer added a comment.
I can't move the functionality into Platform::ConnectRemote because to connect
to a process we need a debugger instance while Platform::ConnectRemote is
called in scenarios where we don't have access to it (from
SBPlatform::ConnectRemote). To clean up the API I adde
tberghammer updated this revision to Diff 42063.
http://reviews.llvm.org/D14952
Files:
docs/lldb-gdb-remote.txt
include/lldb/Target/Platform.h
packages/Python/lldbsuite/test/lldbtest.py
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
packages/Python/lldbsuite/tes
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So my main issue with this is the new virtual
"Platform::GetPendingGdbServerList(...)" function. Can we remove this function
and just put the functionality into Platform::Contect
labath added a comment.
Just a tiny remark from my side..
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:184
@@ +183,3 @@
+std::string hostname;
+// TODO: /tmp/ should not be hardcoded. User might want to override /tmp
+// wit
tberghammer retitled this revision from "Create new "platform process connect"
command" to "Modify "platform connect" to connect to processes as well".
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 41867.
http://reviews.llvm.org/D14952
Files:
docs
