This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb12b35ad4bec: [lldb] Add debugger.external-editor setting
(authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149565/new/
https://reviews.llvm.org/D149565
___
lldb-commits mailing list
JDevlieghere updated this revision to Diff 518558.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Make `external-editor` setting take precedence over `LLDB_EXTRENAL_EDITOR`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149565/new/
bulbazord requested changes to this revision.
bulbazord added inline comments.
This revision now requires changes to proceed.
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396
- static std::optional g_app_fsref;
- static std::string g_app_error;
- static
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149565/new/
https://reviews.llvm.org/D149565
___
lldb-commits mailing list
JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:298
+ llvm::StringRef GetExternalEditor() const;
+ bool SetExternalEditor(llvm::StringRef editor);
mib wrote:
> newline
This was
mib added inline comments.
Comment at: lldb/include/lldb/Core/Debugger.h:298
+ llvm::StringRef GetExternalEditor() const;
+ bool SetExternalEditor(llvm::StringRef editor);
newline
Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396
JDevlieghere created this revision.
JDevlieghere added reviewers: bulbazord, mib, jingham.
Herald added a project: All.
JDevlieghere requested review of this revision.
Add a setting (`debugger.external-editor`) to specify an external editor
instead of having to rely on the `LLDB_EXTERNAL_EDITOR`
