[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d967c95f16: [Damangle] convert rustDemangle to use std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 528006. nickdesaulniers added a comment. - rebase on top of D149675 (I wasn't sure which would land first) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

MaskRay added inline comments. Comment at: llvm/lib/Demangle/RustDemangle.cpp:150 -char *llvm::rustDemangle(const char *MangledName) { - if (MangledName == nullptr) -return nullptr; I see that this patch drops `if (MangledName == nullptr)` (D101444). This

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527895. nickdesaulniers added a comment. - rebase for presubmits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files:

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527507. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - update comments as per @Maskray Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527502. nickdesaulniers added a comment. - rebase, reformat for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files:

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519255. nickdesaulniers added a comment. - update llvm-rust-demangle-fuzzer.cpp call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files:

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

MaskRay accepted this revision. MaskRay added a subscriber: labath. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/ConstString.h:186 operator llvm::StringRef() const { return GetStringRef(); } + //

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519248. nickdesaulniers added a comment. - remove GetStringRef call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files:

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: lldb/source/Core/Mangled.cpp:263 case eManglingSchemeRustV0: -demangled_name = GetRustV0DemangledStr(mangled_name); +demangled_name = GetRustV0DemangledStr(m_mangled.GetStringRef()); break;

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use