bulbazord added a comment.
Looks like this may have broken the Debian buildbot:
https://lab.llvm.org/buildbot/#/builders/68/builds/52162/steps/6/logs/stdio
I'm taking a look and will try to fix forward. If I can't figure it out
quickly, I will revert.
Repository:
rG LLVM Github Monorepo
CH
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG04aa943be8ed: [lldb] Expose a const iterator for
SymbolContextList (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
bulbazord updated this revision to Diff 519690.
bulbazord added a comment.
Explicitly write out type
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
Files:
lldb/include/lldb/Breakpoint/BreakpointResolve
JDevlieghere accepted this revision.
JDevlieghere added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
___
lldb-commits mailing list
lldb-commi
mib added a comment.
LGTM but I'd prefer if we kept the type in the for loop
for (const SymbolContext &sym_ctx : sc_list)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149900/new/
https://reviews.llvm.org/D149900
___
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Please do more of this!
I haven't checked all the replacements for correctness but the direction is
good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: lldb-commits, jplehr, sstefan1.
Herald added a project: LLDB.
The
