[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, kastiglione. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. Most of this is fine. I wonder about avoiding caching the full name and name w/o category & selector name. One of the main uses of this class is to take incoming ObjC names from the ConstString pool, chop them up into full name, name w/o category, and selectorName, wh

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4331048 , @jingham wrote: > Most of this is fine. I wonder about avoiding caching the full name and name > w/o category & selector name. One of the main uses of this class is to take > incoming ObjC names from the

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Ok, I'm back with actual data on this patch. I have a test ObjC app with some UI, it loads a couple hundred modules. I place a breakpoint on main, I run until we hit main, and then I continue. My app will stop at `-[NSBlockOperation main]` after loading all the requir

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord updated this revision to Diff 521414. bulbazord added a comment. Update documentation for clarity Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 Files: lldb/source/Plugins/Language/ObjC/ObjCL

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl added a comment. I'm not opposed to using this implementation, but have you considered using something like the stdlib regex library to do the heavy lifting? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I had not considered it actually... I don't

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. Your test measured setting a found simple breakpoint. That should measure filling all the names caches - we do that the first time you try to set a breakpoint of any sort. But doesn't measure the effects on lookup. I am guessing you will find the same "not much diffe

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Some more numbers: % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App" Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCNam

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. LGTM, Adrian's comment is still outstanding however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I talked to Jonas and did a little research.

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. One more comment inline but otherwise this is fine with me. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelecto

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > Using an llvm s

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. bulbazord marked an inline comment as done. Closed by commit rG915256388f86: [lldb] Refactor ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl wrote: > > Using an llvm string stream to construct

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > bulbazord wrote: > > aprantl wrote: > > > Using an llvm str

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl wrote