[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. debugserver has a memory

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord added a comment. This looks good to me. > This patch does have a regression on > API/macosx/unregistered-macho/TestUnregisteredMacho.py that I wrote last > summer; I have the patch generate JSON for a binary that it had an address > for, but could not read the mach-o headers. This te

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda added a comment. Thanks for the feedback. Testing now & will update the patch in a bit. Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:930-931 +if (!image_infos[i].is_valid_mach_header) { + image_infos_array_sp->AddItem(image_info_dict_sp

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520545. jasonmolenda added a comment. Update to address Alex's comments, fix the testsuite failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520546. jasonmolenda added a comment. Update the patch to stop checking for the `mod_date` key in the JSON reply for each binary. This value is always zero with dyld for the past five+ years. It increases the size of the packet unnecessarily, but lldb

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I have no problem with removing mod_date since you're only removing the requirement in the Darwin-specific code. Also, be sure to remove the portion of the commit message that says this

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e93f91148ae: Add a new report_load_commands option to jGetLoadedDynamicLibrariesInfos (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D150158?vs=520546&id=520578#toc Repo

[Lldb-commits] [PATCH] D150158: Add optional to debugserver's "tell me about all binaries in the process" packet, to limit it to just load addresses and names

jasonmolenda updated this revision to Diff 520580. jasonmolenda added a comment. Updating to reflect what I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150158/new/ https://reviews.llvm.org/D150158 Files: lldb/docs/lldb-gdb-remote.tx