[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

2023-05-12 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc909b491cb5f: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D150402?vs=521453=521757#toc Repository:

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

2023-05-12 Thread Alex Langford via Phabricator via lldb-commits
bulbazord added a comment. In D150402#4337400 , @fdeazeve wrote: > Thanks for doing this! In particular, all the early returns are very welcome > :) > > I suspect you already have this in your radar, but `ExtractFormValueAtIndex` > could probably

[Lldb-commits] [PATCH] D150402: [lldb][NFCI] Change return type of DWARFDebugInfoEntry::GetAttributes

2023-05-11 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: aprantl, JDevlieghere, clayborg, jingham, rastogishubham, fdeazeve. Herald added a subscriber: arphaman. Herald added a reviewer: shafik. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: