This revision was automatically updated to reflect the committed changes.
Closed by commit rG1370a1cb5b97: [lldb] Add support for negative integer to
{SB,}StructuredData (authored by mib).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150485/new/
bulbazord accepted this revision.
bulbazord added a comment.
This revision is now accepted and ready to land.
Alright, looks good to me. Let's see what the bots think!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150485/new/
https://reviews.llvm.org/D150485
mib updated this revision to Diff 524476.
mib marked 2 inline comments as done.
mib added a comment.
Address @bulbazord comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150485/new/
https://reviews.llvm.org/D150485
Files:
lldb/include/lldb/API/SBStructuredData.h
bulbazord added a comment.
Ok, this is a pretty big patch so we probably don't want to leave it in review
for a long time or it just gets harder to land correctly.
I've looked over most of this patch and it looks fine to me. A lot of is rather
mechanical: Changing things like `GetIntegerValue`
mib updated this revision to Diff 524083.
mib marked 2 inline comments as done.
mib edited the summary of this revision.
mib added a comment.
Many changes:
- Change SBAPI templated specialization for 2 distinct methods
`GetUnsignedIntegerValue` & `GetSignedIntegerValue`
- Add new tests
- Update
JDevlieghere added inline comments.
Comment at: lldb/include/lldb/API/SBStructuredData.h:70
/// Return the integer value if this data structure is an integer type.
- uint64_t GetIntegerValue(uint64_t fail_value = 0) const;
+ template T GetIntegerValue(T fail_value = {})
bulbazord added a comment.
This is going to need some tests... And because you're adding templates to the
SBAPI we'll need multiple tests -- Not just on the python side but I think we
should add some actual C++ tests here in `test/API/api/`
Comment at:
mib created this revision.
mib added reviewers: labath, bulbazord, JDevlieghere, jingham.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch refactors the `StructuredData::Integer` class to make it
