[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The darwin kernel debuggi

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. You can do this simpler with a single `std::once_flag`. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:710-715 + std::lock_gu

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord added a comment. In D150621#4344243 , @JDevlieghere wrote: > You can do this simpler with a single `std::once_flag`. +1 I like the idea of this patch a lot! LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda added a comment. Ah, makes sense, will update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda updated this revision to Diff 522813. jasonmolenda added a comment. Update patch to use a std::once operation instead of hand-rolling it, as suggested by Jonas and Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https:

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord accepted this revision. bulbazord added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3227e74e3bf: lldb PlatformDarwinKernel make local filesystem scan lazy (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/