[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder closed this revision. tbaeder added a comment. I merged the changes into the original line number commit and pushed them as https://github.com/llvm/llvm-project/commit/f63155aaa6467bd2610820dfd1996af3bb6029a7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://rev

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder updated this revision to Diff 526557. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 Files: lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py Index: lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere added a comment. I think this test could benefit from switching to string literals (`'''`) and doing a single `self.assertIn` rather than scanning the whole output for every line. Also please use `black` (version 23) to format the test. CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder updated this revision to Diff 523045. tbaeder added a comment. Updated the test and split up the expected output into multiple lines so it's easier to read. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 Files: lldb/test/API/comman

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder added a comment. In D150772#4349595 , @Michael137 wrote: > In D150772#4349592 , @tbaeder wrote: > >> Can you tell me what I have to do so `ninja check-lldb-api` actually runs >> the test? All 1114 tests

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

Michael137 added a comment. In D150772#4349592 , @tbaeder wrote: > Can you tell me what I have to do so `ninja check-lldb-api` actually runs the > test? All 1114 tests are currently marked "unsupported" for me. Did you configure LLDB with `-DLLDB_ENABLE

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder added a comment. Can you tell me what I have to do so `ninja check-lldb-api` actually runs the test? All 1114 tests are currently marked "unsupported" for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

teemperor added a comment. I think, given the support for multi-line expressions, updating the test case is IMHO the right call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150772/new/ https://reviews.llvm.org/D150772 __

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

tbaeder created this revision. tbaeder added a reviewer: LLDB. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Clang prints a margin with line numbers to the left of code snippets now, introduced in htt